Aarni Koskela

Results 331 comments of Aarni Koskela

I took the liberty of implementing a version of what I drafted out in the original post in PR #5875. Decoding ASCII and UTF-8 (["UTF-8 is used by 97.0% of...

@Gagaro `html5lib` optionally requires `chardet` and likely behaves differently if it's not installed. https://github.com/html5lib/html5lib-python/blob/f7cab6f019ce94a1ec0192b6ff29aaebaf10b50d/requirements-optional.txt#L7-L9

@dreid So IOW, it sounds like `flake8` isn't smart enough to realize that no checks are enabled that would actually require it (or pyflakes) parsing the file...

:+1: for unified `!->` and why not `function!` too. Don't see anything wrong with that.

&& isn't unary though, so maybe something could be done to allow it in a prefix/standalone context. Either way making this change would break some programs that currently rely on...

Also seeing a false positive with a pattern like ``` def resolve_from_url(self, url: str) -> dict: local_match = self.local_scope_re.match(url) if local_match: schema = get_schema(name=local_match.group(1)) self.store[url] = schema return schema #...

@SoCuul I took care to use Chalk 4 here.

@MSeal Engines can't register new parameters during the CLI parsing phase though, so having a custom engine for the #425 use case would also require some other method of passing...

Agreed. Installing a font package for production probably shouldn't install 105 packages. ``` $ yarn add @ibm/plex success Saved 105 new dependencies. info Direct dependencies └─ @ibm/[email protected] $ ``` Related...

If this doesn't get merged, the definitions could be maintained in a separate package too. Of course that's a bit of a chore either way.