Akshit Goyal
Akshit Goyal
> Could you please comment on the active comments + fix the merge conflict We cannot make changes to these models as these are same for all the services and...
> Please fix the merge conflict and place PR back in queue resolved
/pr RequestMerge
> @akshitgoyal I know this was technically ARMSignedOff already, which is good - you are now unblocked for RP manifest deployment etc at this point, I don't want to change...
> @akshitgoyal I'm working on adding NetworkSecurityPerimeters to common types, as something like this is clearly urgently needed! Please help me review my PR. > > #28958 @TimLovellSmith I started...
@ramoka178 can we get a signoff on this PR?
sounds good! thanks @TimLovellSmith
> Marking this PR as need to refactor to refer to NSP definitions from > > #28958 > > before merging. > > To be clear the intent of this...
> Marking this PR as need to refactor to refer to NSP definitions from > > #28958 > > before merging. > > To be clear the intent of this...
> @akshitgoyal Please refactor by using references to the [new] common types NSP definitions, letting me know of any blockers > > https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/networksecurityperimeter.json I have refactored the code to use...