Koichi Murase

Results 1368 comments of Koichi Murase

Hmm, this seems like an issue with the unusual use of the shell by the Cursor AI Agent. I'm still unsure why `_omb_cd_dirstack` is unset with the described setup, but...

I'm not sure exactly why the problem happens, but *if variables would be lost in general* with Cursor, it's impossible to work around it in general. In the present case,...

> The fact that we see ++ return in the trace but the script continues executing confirms that the return statement is not working as intended in this context. I...

> Maybe it's worth making environment variable overrides. Here's a snippet from `Lmod`, and although not related to interactive shell, would be good reference: > > ```shell > if [...

> `/etc/profiles.d/modules.sh` is loaded only once in order to define the `module` command. That section is a fallthrough to check if the file is sourced by the `root` and if...

> > * Did you mean just an example to test the root user? > > Yes, just that. Thank you for your clarification. I've been misunderstanding the intent. >...

@jparise I'd appreciate it if you could review this PR. In https://github.com/rcaloras/bash-preexec/pull/152#issuecomment-1963036028, the maintainers seem to require several external reviewers to leave reviews before merging (except for the trivial ones...

> I think it might be nice to mention `__bp_inside_test` in `test/README.md` because users who want to test `bash-preexec.sh` as part of their own tests would also need to set...

@rcaloras Could you take a look at this too?