Akhil Narang
Akhil Narang
Wasn't sure of the original intention of this (seems really old, https://github.com/frappe/frappe/commit/4dab5d62d570e6709adfca2319b319ef8de9e931, so I relied on the flag to let us skip this on a doctype basis: #27311) Will try...
Hmm, strange test failure.
> Also, tests are passing on my local 🤔 Is this with just running a specific test, or all? I can reproduce it locally with `bench run-tests --module frappe.website.doctype.blog_post.test_blog_post`
https://github.com/frappe/frappe/blame/c441be55e60abbf606396543fa3b0af67ef301f0/frappe/model/base_document.py#L827 This is returning `None` after this PR for that specific test - setting `cache=False` does let the test run successfully.
So, on _some_ versions of python/pip (python:3.11 docker image, and whatever frappe_docker and ERPNext develop CI uses), even frappe installation itself breaks because of some dependencies. Considering passing `--use-pep517` unconditionally...
@khanh96le nope, it needs to be passed to `pip install`
Also this reminds me of finishing up #1619 uv seems to handle this well.
Can you share the entire generated URL (you can hide the domain)? Something seems to be wrong in your URL. The default URL doesn't have an `=` after `doctype` like...
@mergifyio rebase
Can you please raise a PR?