Akhil Narang comments

Results 133 comments of


                                            Akhil Narang

refactor: proper msg for users with role

Functionality is fine, not sure about this bullet point, @sokumon / @iamejaaz any suggestions?

refactor: rejuvenation using match/case in format_value

Seems like the formatting is still off.

Form stops to render page on account of a change in multiselect table field breaking the version history (v15.65.2)

@mudux could you share the exact doctype structure - unable to reproduce the issue.

fix: redirect to role permission tab when add roles button is clicked

Please rebase your PR, CI should pass then.

chore(deps): bump bootstrap from 4.6.2 to 5.0.0

@dependabot rebase

chore(deps): bump bootstrap from 4.6.2 to 5.0.0

@dependabot rebase

Download excel shows incorrect total row count

Seems like its because its hardcoded [here](https://github.com/frappe/frappe/blob/develop/frappe/public/js/frappe/list/list_view.js#L31), setting it to something higher than the actual count (999999) did work. (took ~3 seconds to fetch the actual count) Seems like it...

Download excel shows incorrect total row count

> Can this be fixed in a way that large records can show as XXX+ but others show up as actuals? So that is the current behaviour @NehaSan16 - it...

Module not found 'pwd'

Please can you share the entire output

Workspace Not Visible Properly Even After Providing Proper Permissions

Relevant code: https://github.com/frappe/frappe/blob/develop/frappe/utils/user.py#L155-L169 We don't seem to be checking modules directly, just adding modules based on doctypes the user has access to. Can probably also check and add all modules...