Akhil Narang comments

Results 133 comments of


                                            Akhil Narang

fix: add in some indices to speed up Purchase Order deletion (backport #41601)

@mergifyio rebase

refactor: use `json` directly instead of using `frappe.json` (backport #41609)

@mergifyio rebase

fix: Fix file/email attachment name containing percent sign

@mergifyio rebase

fix: Fix file/email attachment name containing percent sign

@cogk could you have a look at the failing test? I'm fine to merge it then.

fix(file): don't allow downloading File attached via restricted Attach field

Some tests are failing

[Timeline] Show title field value if field is Link and show_title_field_in_link is True

Linter and tests failing

refactor: ⚰ delete unused functions

Enough usages that we can't just directly drop things like `save_file` https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/frappe/.*+save_file&patternType=standard&sm=0&groupBy=repo Regarding the others, did you check within the framework codebase or the whole organization? Ideally we can just...

refactor: ⚰ delete unused functions

#27466 _seems_ to fix the issue, will have to see if there's any breakage, but I do prefer just fixing it rather than removing it. (Could deprecate the other unused...

perf: make get requests cacheable

@blaggacao so as-is this PR does nothing unless you modify the nginx configuration to explicitly cache a specific route, correct?

Error encountered while previewing attached files with names containing '%' in the production server

Seems fine with werkzeug, just an issue with NGINX config most likely.