Anthony Towns
Anthony Towns
ACK 355bc6098a7373feb1d59f9651a79e1477d22243
re ACK 686629d2be5545ef59cf0e97f4f3a74c6cde2efa
utACK 77d6d89d43cc5969c98d9b4b56a1e877b473e731
> some who participate in Bitcoin Core's development that is abusive and disruptive For people who are being deliberately abusive and disruptive, a code of conduct can just provide another...
> I'm not sure how either of what you have described is all that different from how we do things today, with the exception that there are no policies in...
> So, in trying to come up with a proof that evicting a descendant package that is below the minrelayfeerate from the mempool is safe to do because we'd never...
utACK f0209248e1baea41aae72147c973f1f5aa27c97b Seems reasonable to me. Not 100% confident over delaying stopping the threads until the destructor; but also about equally unsure about how it works now...
> add a default initializer for `kernel::ChainstateManagerOpts::worker_threads_num` Yikes. Work on adding [`cppcoreguidelines-pro-type-member-init`](https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/pro-type-member-init.html)` to clang-tidy maybe? reACK 5a7932f395c675fad332cbcd0498bb9fefcb33e0
> * We can remove these transactions in `TrimToSize()`, but 2500 is not within our acceptable limits. I'm not sure I see why this is a problem? Can't we have...
@glozow > My concern was whether it would be problematic to have many such transactions to trim, hence these changes beforehand. If we instead decide that we're ok with this,...