Anthony Towns
Anthony Towns
> I believe most of them use libbitcoinconsensus for testing script execution, with the only exception of `floresta`? While I found it beneficial for cross-testing complex scripts, the absence of...
> btcd libbitcoin optionally uses https://github.com/libbitcoin/libbitcoin-consensus which has a similar name, but doesn't seem to have any code in common. AFAIK, btcd reimplements all the consensus logic in go.
> Could you clarify what deprecation will actually mean for 27.0, and then the future steps? I would have thought that for 27.x you'd just add the deprecation note, and...
> Rather than spending time arguing about removing some silly tests, I think there's a compromise here: Let's do the deprecation now (the readme changes as well as a release...
Concept ACK -- always makes sense to debug log disconnection reasons IMO
This should be updating `MinBIP9WarningHeight` above the taproot activation height (otherwise you should see `"warnings": "Unknown new rules activated (versionbit 2)"` due to miner signalling)
This implements ~most of~ ~all of~ most of my comment https://github.com/bitcoin/bitcoin/pull/25203#issuecomment-1401126785 I figure the main benefit of categories is to be able to selectively turn logging on/off -- but for...
sample scripted diff code: ``` sed -i 's/LogPrintLevel(\(BCLog::[^,]*\), BCLog::Level::Debug,/LogDebug(\1,/' net_processing.cpp dbwrapper.cpp net.cpp node/txreconciliation.cpp validation.cpp sed -i 's/LogPrintLevel(\(BCLog::[^,]*\), BCLog::Level::Error, */LogError(/' net.cpp txmempool.cpp sed -i 's/LogPrintLevel(\(BCLog::[^,]*\), BCLog::Level::Warning, */LogWarning(/' net.cpp sed -i 's/LogPrintf(/LogInfo(/'...
> Is this ready for review, or any reason why this is still in draft? I was hoping for early feedback from @jonatack and initially wasn't happy with the original...
> Is this ready for review, or any reason why this is still in draft? Err, perhaps it was because I made some more changes and didn't push them? [EDIT:...