Andrew Kryczka

icon company Facebook icon location Bay Area

Results 126 comments of Andrew Kryczka

ReadOptions::verify_checksums flag is not propagated to reads of meta blocks (index, filter, compression dictionary etc.)

I think the ReadOptions, including verify_checksums, should be propagated to meta-block reads. We know cases they currently aren't, such as this one discovered recently - https://github.com/facebook/rocksdb/pull/10438/files#r932893036. But I have yet...

Multireadrandom in benchmark.sh doesn't use batched MultiGet

Not sure if you wanted this up-for-grabs or assigned to yourself. Please correct it if my guess was incorrect.

Prevent a case of WriteBufferManager flush thrashing

@cheng-chang I talked to @siying and he prefers `WriteBufferManager` to be strict, while this PR would make it less strict. so I am not sure this change is desirable, although...

rocksdb restart failed

This step seems problematic: "2） move the rocksdb data". Why would the DB be openable if the data is moved?

rocksdb restart failed

Maybe strace the process to find out what are the paths for the CURRENT file and MANIFEST file it is reading during step two? It must be reading a MANIFEST...

Request for API support for requesting compaction and waiting for it to finish (feature request)

Is it fixed by #10524?

Introduce tail log entry to the end of a log file

quick question: don't we know 4.log is complete if its latest seqnum is one less than 5.log's earliest seqnum?

Mempurge instead of flush is initiated even if only one memtable is picked by flush job

Should it be assigned or up-for-grabs?

Mempurge instead of flush is initiated even if only one memtable is picked by flush job

Sorry I'm not currently familiar with mempurge. @riversand963 are you able to help answer the questions?

Fail DB::Open if hashing features enabled with incompatible Comparator

> It's not totally clear to what users should do if they only provide certain kinds of keys as input and expect the comparator to only deal with those keys....