rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Introduce tail log entry to the end of a log file

Open siying opened this issue 6 years ago • 4 comments

Right now, after a machine crash, we don't know whether a log file is complete. For example, we may contain 4.log 5.log but 4.log is partial, and has several entries missing in the end. By adding a tail entry to the end of each closed log file, we can detect this case, so that we know we shouldn't continue relaying 5.log

siying avatar Jun 06 '18 18:06 siying

Can I work on this?

rozuur avatar Oct 03 '18 15:10 rozuur

quick question: don't we know 4.log is complete if its latest seqnum is one less than 5.log's earliest seqnum?

ajkr avatar Oct 12 '18 01:10 ajkr

@ajkr not the case if people ever write with WriteOptions.disableWAL=true.

siying avatar Oct 12 '18 15:10 siying

@rozuur you are welcome to take it.

siying avatar Oct 12 '18 15:10 siying