Andrew Kryczka

Results 126 comments of Andrew Kryczka

Do you have a copy of the original DB to experiment with? If so, can you show the `format_version` from the OPTIONS file in the DB directory? ``` $ grep...

> Even then I d like to do things like adding sst files which require newer version of ldb while still using the resulting database with OpenEthereum. FYI, I suspect...

I stressed it overnight and suspect there's a bug somewhere as there's some suspicious failures. Internal links - https://www.internalfb.com/intern/skycastle/run/49539595908999967 - https://www.internalfb.com/intern/skycastle/run/99079191810063385 - https://www.internalfb.com/intern/skycastle/run/22517998144769851

> I stressed it overnight and suspect there's a bug somewhere as there's some suspicious failures. Internal links > > * https://www.internalfb.com/intern/skycastle/run/49539595908999967 > * https://www.internalfb.com/intern/skycastle/run/99079191810063385 > * https://www.internalfb.com/intern/skycastle/run/22517998144769851 Cause is...

@DRoppelt @adamretter Can we use a system property to indicate musl vs. non-musl when building JARs for a particular libc, e.g., "rocksdbjni-7.6.0-linux64.jar" and "rocksdbjni-7.6.0-linux64-musl.jar"?

I still lean towards new function names for compatibility. Perhaps they can have a suffix like "_err". Or maybe "2" or "v2" is a better suffix to indicate they're an...

Yeah I'd go with new functions with a "v2" suffix for fixing up APIs like this (adding `char** errptr` to APIs that can fail). cc @pdillinger, @siying, @ltamasi in case...

It looks like you are performing writes with 10+GB of data. ``` Interval writes: 2 writes, 33M keys, 2 commit groups, 1.0 writes per commit group, ingest: 24004.10 MB, 40.01...

In the provided LOG file, the number of L0 files is always growing, which is due to disable_auto_compactions=1. This at least costs extra CPU on the read side since every...

Summary of discussion on why it might not work yet: we don't know of anything in db_stress that verifies concurrent writes and non-snapshot reads on the same key because those...