Alex Kavanagh comments

Results 84 comments of


                                            Alex Kavanagh

not support python3?

It's possible that the centos/redhat support is currently only Python2 at the moment, so yes this would be a bug.

Ought to introduce a helper for "release = lsb_release()['DISTRIB_CODENAME'].lower()"

Thanks @dshcherb for starting this off. I've left a review on the PR. Thanks!

Expose RabbitMQ port in the context class

@freyes I updated the branch to master (as a precursor to merging the PR), but sadly one of the tests is now failing; you should be able to pull those...

cannot use charmhelpers.core.hookenv on python2 due to addition of enum import

This is a bit odd. I just did this in py2 on a bionic host: ``` Python 2.7.18rc1 (default, Apr 7 2020, 12:05:55) Type "copyright", "credits" or "license" for more...

cannot use charmhelpers.core.hookenv on python2 due to addition of enum import

> @ajkavanagh you might have package python-enum34 installed (which backports enum for py2). I've run into this as well when developing on my workstation: everything looked good until I deployed...

`git add` for untracked files in charm_helpers_sync.py

I'm not sure I understand your workflow here. With a 'legacy' charm, normally `make sync` is run manually to bring the charmhelpers files into the charm. Then one manually checks...

`git add` for untracked files in charm_helpers_sync.py

So, it would probably be reasonably complicated. In theory, the charm may be managed under a different vcs than git, so the code would need to check that before doing...

Suggestion to check if port is already open before the port is opened?

A couple of thoughts here (which may be off base): 1. We could change `def open_port(..)` to fail silently if the port is already open, assuming there's an error message...

Suggestion to check if port is already open before the port is opened?

Okay, let's go for '4' then: I've opened a bug on juju: https://bugs.launchpad.net/juju/+bug/1741028

Add a deprecation/status message to the README

Ping - just seeing if this is still needed.