Alex Kavanagh

Results 84 comments of Alex Kavanagh

> Apparently, the sequence of the tests that run has changed from one python version to another and this might break some tests. So, this probably means that the tests...

> That is right. I just looked at the test_ceph_context_ec_pool_no_rbd_pool and the problem there is that is missing the env var for JUJU_UNIT_NAME that was happening on test test_save_scriptrc. Now...

@vorlonofportland please could you add a reason for why this PR is needed. e.g. is there a bug that it is fixing? Thanks.

#558 is a temporary fix so that work can continue; the proper solution is to get it to work with 20.3.1

It looks like tests are failing: `tox -e py310` (that uses nose2): ``` ---------------------------------------------------------------------- Ran 1936 tests in 7.439s FAILED (errors=5) Name ```

Hi @gnuoy ; code looks good. Is there a gerrit review or similar that it is being exercised against? Thanks!

Associated charm change (for glance): https://review.opendev.org/c/openstack/charm-glance/+/750224

It seems that this code in `tests/fetch/test_bzrurl.py`: ```python try: from charmhelpers.fetch import ( bzrurl, UnhandledSource, ) except ImportError: bzrurl = None UnhandledSource = None ``` should actually also check for...

@ChrisMacNaughton is this still current? If so, it's got a conflict in `cert_utils.py`. Thanks!

It's possible to validate it, although it would need to be done on a charm-by-charm basis to do the verification prior to the value (attempted to) being used. Otherwise, it's...