charm-helpers icon indicating copy to clipboard operation
charm-helpers copied to clipboard

Ought to introduce a helper for "release = lsb_release()['DISTRIB_CODENAME'].lower()"

Open ajkavanagh opened this issue 7 years ago • 2 comments

charm-helpers itself, and lots of charms, use this exact line:

release = lsb_release()['DISTRIB_CODENAME'].lower()

There ought to be a helper that does this, and do it through the code base.

Note, that this will also have to be done for the centos host_factory too.

ajkavanagh avatar Dec 05 '18 09:12 ajkavanagh

@ajkavanagh

The Ubuntu portion: https://github.com/juju/charm-helpers/pull/268

dshcherb avatar Jan 27 '19 05:01 dshcherb

Thanks @dshcherb for starting this off. I've left a review on the PR. Thanks!

ajkavanagh avatar Jan 28 '19 07:01 ajkavanagh