Tony Aiuto

Results 397 comments of Tony Aiuto

I don't know enough about how mac dynamic linking as you used it (with both linkstatic and linkshard) is supposed to work to comment yet. To me, the cc_binary example...

Have you tried the "attributes" setting on `pkg_files`. https://bazelbuild.github.io/rules_pkg/latest.html#pkg_files-attributes

Compatibliy with gnutar is not a goal we have been aiming for. We've done a lot of work to explicitly detect duplicate files because they are generally a sign that...

Thanks for those examples. How about this proposed API Add `allow_dups_from_deps` as an attribute to pkg_tar. - It works like concatenate from gnutar. - The comment should mention that `deps`...

SGTM. Except my proposal about testing is not sufficient. You need to be able to specify that a file appears N times, and possibly what the content for each is....

This seems like a reasonable feature if anyone would like to implement it.

This not possible given the relative ordering of analysis and execution in Bazel. The file name is defined at analysis time, which must complete before we execute the actions required...

Sorry I missed this entirely. Yes. I'm happy to accept PRs against this. I have some half finished things in the works. I will try to put them up as...

I'm not sure what the suggested changes are. I think the summary is - add "allow_directory_overwrites" in pkg_* - if two base directories map to the same place, still allow...