Tony Aiuto

Can you provide a detailed writeup (preferablye in an external doc) about what rules_js does, and then what you need to accomplish. I won't have the time to do this...

I'm ooo until July 7. Will pick up thead then. On Thu, Jun 23, 2022, 12:20 AM Kurt K ***@***.***> wrote: > Just to chime in, I would also appreciate...

OK. I am in a mood to deal with this now. I presume we can have dangling, arbitrary symlinks, so that is not the problem. My hunch is that you...

Is #603 the right kind of test case?

I need help understanding the requirement here. Please look at #603. It - creates a tree of symlnks that looks like node_modules - passes that as `srcs` input to pkg_tar...

Or..... maybe I am missing the obvious. Is the requirement: Real check in files, or the result of a tree artifact. - bin/foo - foo -> bin/foo - bar ->...

> the principled fix would be that bazel exposes two new fields to FileApi named is_symlink and symlink_target which points to another File Yes. That really should happen. But that...

@thesayyn Can you take a look at #603 to confirm that //tests/tar:relative_links_tar reproduces the problem here. If you were to patch it and do: ``` blaze build //tests/tar:relative_links_tar tar tvf...

More thinking about this. - I believe that symlinks in tree artifacts should be preserved in pkg_tar or pkg_zip by default. - There is no need to implement an expand...

@thesayyn @alexeagle I don't want to wait for https://github.com/bazelbuild/bazel/pull/15866 and bazel 6.x to make progress on this. If you think the test cases in #603 cover enough of the space...