Ervin Hegedus

Results 605 comments of Ervin Hegedus

How do you want to compile this test? And with which compiler? I built it with `gcc` and it runs as well without problem. Btw I don't see the reason...

Hi @chenuduss, thanks for reporting this. Unfortunately this is a known issue in libmodsecurity3, see [this list](https://github.com/owasp-modsecurity/ModSecurity/issues?q=is%3Aissue+is%3Aopen+memory+leak) or especially the issue #2848. The problem is not in `vg_replace_malloc.c:422` as you...

Hi @touchweb-vincent, thanks for this contribution! Could you add some tests which provide that the parser works as we expect with the mentioned tokens? You can see existing [test](https://github.com/coreruleset/secrules_parsing/blob/main/tests/test_api.py) file...

> I honestly don’t know what else to say - it’s just additional debugging. Then you should add that: the PR adds more information and helps debugging. And you can...

> You're right, I’ve updated the PR accordingly. Thanks, I think now it's fine. But I tried your modification with a real example (I made a rule with wrong syntax...

> I did a standard install - I don’t remember running any exotic commands. > > `pip show textx` > > Name: textX Version: 3.1.1 uhmm, it seems like I...

> We definitely should start adding tests for these changes 🤔 Should I add a (few) test(s) before merge?

Hi @Kubas556, thanks for this report - unfortunately I can't open the image. Could you share the error in simple text? Btw I tried to parse the mentioned file but...

> I need full model of modsec rule so i could recreate it using my own definitions in C# classes If it's enough that you get a yaml/json structure of...