secrules_parsing icon indicating copy to clipboard operation
secrules_parsing copied to clipboard

fix: setenv syntax

Open airween opened this issue 2 months ago • 2 comments

In issue (#92) they explain the setenv action does not allow both syntax: quoted (with ') and unquoted form.

I think the setenv syntax is the same as setvar: it can be quoted with a single quote mark, can have a ! character to delete the env var, and can contain a name, a = and a value.

This fixes that and closes #92.

airween avatar Oct 29 '25 20:10 airween

We definitely should start adding tests for these changes 🤔

fzipi avatar Oct 29 '25 20:10 fzipi

We definitely should start adding tests for these changes 🤔

Should I add a (few) test(s) before merge?

airween avatar Oct 29 '25 20:10 airween