Ervin Hegedus
Ervin Hegedus
Hi @eduar-hte, many thanks for this great PR. Also thanks for adding `false positive` labels to `cppcheck` suppression's. I have only one question regarding the new inline suppression's: are those...
> Yes, the new version reported some new issues, some of which were addressed with changes to the code as they were correct (see commits related to using the `override`...
Thanks for the PR again and for the detailed explanations. I'm merging this now.
Do we want to keep the names? Eg. is the `crs-rules-check` is a good name or do we want to continue with `rules-check`? Or may be `coreruleset-check` (just a stupid...
> Question 2: How many of the utilities that we want to keep will break if they no longer live in /util? E.g. hard coded paths and similar? (E.g. it...
You wrote above: > [APPROVED_TAGS](https://github.com/coreruleset/coreruleset/blob/main/util/APPROVED_TAGS) file is used by crs-rules-check. Must be moved with the script I think this is not a good idea. Consider someone wants to add new...
> the script might not need to know which tags are approved. That's why there is the `-t` option. We can pass the file with that which contains the approved...
Hi @Orgoth, which version do you use? If you use libmodsecurity3 and Nginx, you should try to put into a `location` block: ``` location /api/endpoint { modsecurity_rules ' SecPcreMatchLimit 1024...
Please feel free to close this issue if you could solve that.
I'm not sure if it's possible - @marcstern what do you think?