Andrew Standley
Andrew Standley
Yes! I'm all for improving OpenAPI 3 support. Thanks for the suggestion Sytten!
Probably could combined this with #12
Seems like a bug to me. It was original a legacy method marked for deprecation https://github.com/plangrid/flask-rebar/blob/69d378cfb11538ad567d697e514a298cc7838441/flask_rebar/swagger_generation/authenticator_to_swagger.py#L203
Definitely a bug. We missed removing those lines in https://github.com/plangrid/flask-rebar/pull/216 ðŸ˜
🤔 I think this might also be an instance vs class issue. @mattcarp12 Do you still get an error with ``` rebar = Rebar() swagger_generator = SwaggerV2Generator(authenticator_converter_registry=custom_auth_registry) registry = rebar.create_handler_registry(swagger_generator=swagger_generator)...
This would be an amazing enhancement, but it's a doozy. 1) Looking over Marshmallow it seems like there's a lot of built in assumptions that you are dumping everything at...
@twosigmajab This is fantastic! It's a huge improvement. However I'm against removing all references to `RequestSchema/ResponseSchema`; I'm completely pro adding documentation that discusses different philosophies on API design and when...
Hey Sytten, Thanks for the suggestion! I think it's worth noting that we have fairly strongly branded flask-rebar as a Flask based library (since it's in the name and all...
I'm still conflicted. I strongly feel that the "description" and "example" fields for a [SchemaObject](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#schema-object) map well to python docstrings; their intention is non-function, they are documentation for a human...
I think I'm convinced at this point that rendering the example using metadata in the Schema's fields is the way to go here. That's probably best suited to a separate...