flask-rebar icon indicating copy to clipboard operation
flask-rebar copied to clipboard

Compatibility with Quart

Open Sytten opened this issue 5 years ago • 4 comments

Since the future is ASGI (Django announced support for v3), it would be a good idea for flask-rebar to support at least Quart to provide a smoother transition.

Sytten avatar Sep 21 '19 17:09 Sytten

Color me intrigued 😄 Haven't had much time for non-firefighting Flask-Rebar stuff of late but at first glance this does seem like something worth considering. We'd have to figure out how we deal with version restrictions (Quart requiring Python 3.7+). Should probably also be jettisoning support for Py2 as it reaches end of life so tagging this one as a "v2.0" for now and perhaps we can tackle those at the same time.

RookieRick avatar Sep 27 '19 18:09 RookieRick

Hey Sytten, Thanks for the suggestion!

I think it's worth noting that we have fairly strongly branded flask-rebar as a Flask based library (since it's in the name and all 😄) and werkzeug/Flask appear to have committed to supporting ASGI eventually. (https://github.com/pallets/werkzeug/issues/1322)

That said it definitely seems like there are a ton of barriers for that process. If we can support Quarts in the mean time without breaking Flask support, that seems like a win to me!

(Side note: Wait Django finally announced official support for ASGI?!?! I'm so happy 💟 . I still have nightmares about getting django-channels playing nice....)

airstandley avatar Sep 27 '19 19:09 airstandley

🤣 Yeah the name thing did cross my mind too

RookieRick avatar Sep 27 '19 19:09 RookieRick

ASGI is eating the world :) The good thing with Quart is that it's API compatible with Flask (thats why I suggested this framework) and most library are already working with it. I think the only thing we can't use is current_app.

Sytten avatar Sep 29 '19 02:09 Sytten