openshift-docs
openshift-docs copied to clipboard
RHDEVDOCS-5562: Creating content for Using Argo Rollouts to route traffic by OpenShift Routes
Version(s):
1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [x] QE has approved this change.
Additional information:
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
…ffic manager for Argo Rollouts
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Hi @Dhruv-Soni11. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
🤖 Thu Jun 20 06:17:00 - Prow CI generated the docs preview:
https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery.html
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @ishitasequeira QE review: @varshab1210 Peer review: @Srivaralakshmi
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
This PR has been repointed to gitops-docs-main
branch. gitops-docs
is no longer in use and will be deleted presently. The gitops-docs-main branch uses the OpenShift Prow CI instead of Travis for builds.
Related: https://github.com/openshift/openshift-docs/pull/74041
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.12
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
^^ updated comment #1 URL with updated build.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest
/retest
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [x] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro
Link to docs preview:
https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Required changes:
https://github.com/openshift/openshift-docs/pull/72104#discussion_r1635980285 https://github.com/openshift/openshift-docs/pull/72104#discussion_r1639875987
LGTM otherwise!
Required changes:
#72104 (comment) #72104 (comment)
LGTM otherwise!
Hi @varshab1210, for the first comment I will add the link once the content in the other PR is merged. Also, I have added the feedback for the second comment.
/label peer-review-needed
/ok-to-test
@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.
In response to this:
Version(s):
1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5562
Link to docs preview:
https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery
SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest
/retest
/retest
/retest
Left a few comments but otherwise looks good to me, nicely done!
Hey @skopacz1 - Thanks for providing the comments. I have fixed all of them. PTAL.
@Dhruv-Soni11: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/label merge-review-needed
Merge review LGTM.