openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

RHDEVDOCS-5562: Creating content for Using Argo Rollouts to route traffic by OpenShift Routes

Open Dhruv-Soni11 opened this issue 11 months ago • 17 comments

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [x] QE has approved this change.

Additional information:

Dhruv-Soni11 avatar Feb 26 '24 09:02 Dhruv-Soni11

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

…ffic manager for Argo Rollouts

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 26 '24 09:02 openshift-ci-robot

Hi @Dhruv-Soni11. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Feb 26 '24 09:02 openshift-ci[bot]

🤖 Thu Jun 20 06:17:00 - Prow CI generated the docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery.html

ocpdocs-previewbot avatar Feb 26 '24 09:02 ocpdocs-previewbot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 26 '24 11:02 openshift-ci-robot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira QE review: @varshab1210 Peer review: @Srivaralakshmi

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 26 '24 11:02 openshift-ci-robot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 26 '24 13:02 openshift-ci-robot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 26 '24 13:02 openshift-ci-robot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 26 '24 13:02 openshift-ci-robot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--docspreview.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 02 '24 13:04 openshift-ci-robot

This PR has been repointed to gitops-docs-main branch. gitops-docs is no longer in use and will be deleted presently. The gitops-docs-main branch uses the OpenShift Prow CI instead of Travis for builds.

Related: https://github.com/openshift/openshift-docs/pull/74041

aireilly avatar Apr 02 '24 13:04 aireilly

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.12

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Apr 03 '24 07:04 openshift-ci-robot

^^ updated comment #1 URL with updated build.

aireilly avatar Apr 03 '24 07:04 aireilly

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @ishitasequeira QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 08 '24 08:05 openshift-ci-robot

/retest

Dhruv-Soni11 avatar May 08 '24 13:05 Dhruv-Soni11

/retest

Dhruv-Soni11 avatar May 10 '24 07:05 Dhruv-Soni11

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [x] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 10 '24 08:05 openshift-ci-robot

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562?src=confmacro

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 22 '24 08:05 openshift-ci-robot

Required changes:

https://github.com/openshift/openshift-docs/pull/72104#discussion_r1635980285 https://github.com/openshift/openshift-docs/pull/72104#discussion_r1639875987

LGTM otherwise!

varshab1210 avatar Jun 18 '24 12:06 varshab1210

Required changes:

#72104 (comment) #72104 (comment)

LGTM otherwise!

Hi @varshab1210, for the first comment I will add the link once the content in the other PR is merged. Also, I have added the feedback for the second comment.

Dhruv-Soni11 avatar Jun 18 '24 13:06 Dhruv-Soni11

/label peer-review-needed

Dhruv-Soni11 avatar Jun 18 '24 13:06 Dhruv-Soni11

/ok-to-test

skopacz1 avatar Jun 18 '24 17:06 skopacz1

@Dhruv-Soni11: This pull request references RHDEVDOCS-5562 which is a valid jira issue.

In response to this:

Version(s):

1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-5562

Link to docs preview:

https://72104--ocpdocs-pr.netlify.app/openshift-gitops/latest/argo_rollouts/using-argo-rollouts-for-progressive-deployment-delivery#adding-openshift-routes-as-a-traffic-manager-for-argo-rollouts_using-argo-rollouts-for-progressive-deployment-delivery

SME review: @jgwest QE review: @varshab1210 Internal peer review: @eromanova97 , @Srivaralakshmi Peer review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 19 '24 06:06 openshift-ci-robot

/retest

Dhruv-Soni11 avatar Jun 19 '24 07:06 Dhruv-Soni11

/retest

Dhruv-Soni11 avatar Jun 19 '24 07:06 Dhruv-Soni11

/retest

Dhruv-Soni11 avatar Jun 19 '24 07:06 Dhruv-Soni11

/retest

Dhruv-Soni11 avatar Jun 19 '24 09:06 Dhruv-Soni11

Left a few comments but otherwise looks good to me, nicely done!

Hey @skopacz1 - Thanks for providing the comments. I have fixed all of them. PTAL.

Dhruv-Soni11 avatar Jun 19 '24 10:06 Dhruv-Soni11

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 20 '24 06:06 openshift-ci[bot]

/label merge-review-needed

Dhruv-Soni11 avatar Jun 20 '24 13:06 Dhruv-Soni11

Merge review LGTM.

bscott-rh avatar Jun 20 '24 15:06 bscott-rh