Alex

Results 951 comments of Alex

What if you're using SauceLabs, where Selenium isn't running locally and you can't really check that file exists?

Shouldn't we move the check deeper into the code, so that no matter how upload is invoked we still check, that does exist? Maybe into Mink code itself?

> The screenshot filename "firefox_2016-07-12T15:19:21+00:00.578f8b3deeff62.22313382.png" contains invalid characters on Windows. Which exactly characters?

> This fails for PHP 5.3. I'm not sure what to do with this. Nothing. The fixing commit is https://github.com/Behat/Behat/commit/3f5c2060d394de31b4842858f2b10b39c8fb335d , but since MinkExtension tests are using stable version of...

I'm not sure if we have any tests that confirm, that options from `.behat.yml` are transferred correctly to the driver instance returned. If we have, then should update them.

If there are none, then none needed.

The https://github.com/minkphp/MinkZombieDriver/pull/183 is merged now and (if this repo is using dev versions of all drivers) we can actually see if it works.

@TerjeBr , the current state of PR is @stof and @berliner haven't replied to the only question I've asked about code changes. Only that is blocking the merge.

PR is ready for merge. I'm missing merge permissions on this repository unfortunately, so it's the @stof , who can do the merging part here.

No way currently. I'm not sure how this can be changed without doing a BC break. You're welcome to send a PR.