MinkExtension icon indicating copy to clipboard operation
MinkExtension copied to clipboard

Published 20 hours ago • verified publisher icon Behat

Screenshot filename has invalid characters

Open ollietb opened this issue 8 years ago • 2 comments

The screenshot filename "firefox_2016-07-12T15:19:21+00:00.578f8b3deeff62.22313382.png" contains invalid characters on Windows. This PR changes it to "firefox_2016-07-20_16.31.25_578f8b3deeff62.22313382.png"

ollietb avatar Jul 20 '16 14:07 ollietb

The screenshot filename "firefox_2016-07-12T15:19:21+00:00.578f8b3deeff62.22313382.png" contains invalid characters on Windows.

Which exactly characters?

aik099 avatar Jul 20 '16 15:07 aik099

@aik099 The colons are reserved characters in Windows file systems https://msdn.microsoft.com/en-gb/library/windows/desktop/aa365247%28v=vs.85%29.aspx?f=255&MSPPError=-2147217396. Altough the + is valid, I think it's best to stick to normal filename characters.

ollietb avatar Jul 21 '16 12:07 ollietb