Alex comments

Results 951 comments of


                                            Alex

fillField fails with longer text

Doesn't look like bug in MinkExtension, but rather with a particular driver (or even PhantomJS bug). And therefore I suggest reporting in relevant Mink driver repo instead. Does same problem...

Fixes #266: Stop sessions if exception thrown when resetting

> I'm wondering whether we should handle it in Mink itself. ... @stof , something like session self-restart on failed stop? Like new parameter of `Session::stop` method, e.g. `$restartOnFailure =...

Expectations not inherited on "new static()"

The https://github.com/padraic/mockery/blob/master/library/Mockery/Generator.php#L711-L738 code seems to do the import but it's only executed on instance mocks not all the time.

Display a stack trace of the calls when the expected count doesn't match the actual count

I'm not sure what of stack traces is recorded, but I recommend to store already human friendly output instead of complete stack trace with all the objects. By not storing...

The `PHPUnit\Framework\TestCase::prophesize` method not polyfilled

@stof, any way to make https://github.com/phpspec/prophecy-phpunit work on other PHP versions?

The `PHPUnit\Framework\TestCase::prophesize` method not polyfilled

@jrfnl , the https://github.com/phpspec/prophecy-phpunit/issues/34 is merged now. You can send PR with autoloader now. Thank you.

Checking hasUpdate() should not require is_writable for phar file.

What would be a use case for this?

Checking hasUpdate() should not require is_writable for phar file.

> In the event of a failure when an unprivileged user uses the phar, she should be able to see if the phar is up to date, and request that...

Obey HTTP_PROXY environment variables

Only, when invoked from CLI. See https://httpoxy.org/ for more details about security vulnerability related to `HTTP_PROXY`.

Manifest file strategy

Apparently the review stage took longer than expected.