Ahson Khan
Ahson Khan
Upstream dependencies shouldn't be relying on or referencing fields that are marked `_internal`. Similarly, types and methods prefixed with `_az` are private implementation (that aren't documented) and shouldn't be used....
Follow-up from https://github.com/Azure/azure-sdk-for-c/pull/1816 cc @RickWinter
We are at ~80% branch coverage, which could be improved to get closer to ~100%  https://dev.azure.com/azure-sdk/public/_build/results?buildId=990064&_a=summary&tab=ms.vss-codecoverage-web.code-coverage-details&view=codecoverage-tab  https://github.com/Azure/azure-sdk-for-c/blob/d9ef1bf5c5bdc775fcf5a86f144d27a272054a49/sdk/src/azure/core/az_base64.c#L319-L324 See examples on how to add tests for preconditions here: https://github.com/Azure/azure-sdk-for-c/blob/9f5a6334863ebbf214c6e2fbd5d6e3fce52fe0de/sdk/tests/iot/hub/test_az_iot_hub_client_c2d.c#L41-L54
Follow up from https://github.com/Azure/azure-sdk-for-c/issues/1082
Use def/undef in file along with an error (don't use internal). Suggested by @barcharcraz
See https://github.com/Azure/azure-sdk-for-c/pull/1354#discussion_r494668042 For the time being, we have pinned the vcpkg version that we use. The git hashes for our dependencies come from the following version of vcpkg and are...
Similar to using `BuildType` for the CI tests, we should make sure the live tests run on release builds: https://github.com/Azure/azure-sdk-for-c/blob/803d010ece9e442cfc01720f6b13367fdf87c780/eng/pipelines/templates/jobs/archetype-sdk-tests.yml#L8-L32 cc @danieljurek, @antkmsft
See https://github.com/Azure/azure-sdk-for-cpp/issues/732#issuecomment-707449794 For example: `UNIT_TESTING` -> `BUILD_TESTS` `TRANSPORT_CURL` -> `BUILD_CURL_TRANSPORT` etc. Apply similar renaming to all other options and update docs.