Ahson Khan comments

Results 106 comments of


                                            Ahson Khan

Add preconditions to the doxygen docs

Nice! > Is this something we would want to add to all the API's? I think we should add them. Good idea.

Add preconditions to the doxygen docs

@RickWinter, @antkmsft, @vhvb1989, @JeffreyRichter - thoughts?

Install and use cmake 3.10 on the agent machines

Btw, we also use `add_compile_definitions` which is a cmake 3.12 feature. I just tried on WSL (which uses 3.10.2), and it fails to build the SDK because of this: https://github.com/Azure/azure-sdk-for-c/blob/644d483e039a1d43e848c4cee344cdc8f7547b67/CMakeLists.txt#L16-L34...

Release pipelines need to update the version in main

This is relevant whenever the release is triggered from a feature branch. cc @danieljurek

Intermittent vcpkg bootstrap failure: "Failed to download file", because "Timeout was reached" when downloading zlib from sourcefourge

Failed again: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1719016&view=logs&j=a5fc39c3-d79c-51c5-1c7e-826b06cf306e&t=903cd952-2868-525e-140c-2f3f9f61951e&l=244 ```text 2022-07-19T18:26:03.2827856Z Elapsed time for package cmocka:x64-windows-static: 48.98 s 2022-07-19T18:26:03.2828616Z Starting package 2/6: zlib:x64-windows-static 2022-07-19T18:26:03.2829352Z Building package zlib[core]:x64-windows-static... 2022-07-19T18:26:03.6899281Z -- Downloading http://www.zlib.net/zlib-1.2.11.tar.gz... 2022-07-19T18:26:03.6900775Z -- Downloading http://www.zlib.net/zlib-1.2.11.tar.gz... Failed....

Consider adding simple "debug" and "release" flavors of compiling the SDK

cc @gilbertw - in case you have some thoughts on this (or regarding triaging)

Add JSON parser and builder sample usage code snippets to an .md file as part of docs.

Thanks for the suggestion, @ericwol-msft

Add JSON parser and builder sample usage code snippets to an .md file as part of docs.

From https://github.com/Azure/azure-sdk-for-c/issues/842 by @momuno > **Is your feature request related to a problem? Please describe.** > The az_json_parser does not have quality documentation for the end-user. The only current examples...

Reduce uses of static_cast to size_t in storage code, including lambdas

The tricky part is that some of these lengths and offsets are coming from the user options/http range which is int64_t. We'll probably need some sort of argument guards for...

Reduce uses of static_cast to size_t in storage code, including lambdas

> The int64_t looks good to me here @JeffreyRichter are you suggesting we do some casting, OR do some argument validation and throw? The `ReadToCount` API expects `size_t`, we cant...