Benjamin Wang comments

Results 627 comments of


                                            Benjamin Wang

Re-write rw-heatmaps tool in golang

OOPS, I misread the comment above, I closed the PR instead of this issue. I am good as long as eventually we can integrate the line chart. Please feel free...

Fix tx buffer inconsistency if there are unordered key writes in one tx.

Please read https://github.com/etcd-io/etcd/issues/17247#issuecomment-1895725142

Use raft log to patch operation history in Robustness tests

Overall it seems not a good idea to verify etcd's correctness depending on WAL data. It's a little strange that you verify etcd's correctness, but you trust the WAL data...

etcd won't run on OpenBSD: set keepalive period not supported

OpenBSD has no user-settable per-socket TCP keepalive options. [tcpsockopt_openbsd.go#L13-L15](https://github.com/golang/go/blob/53279a6af372e3708afe8eaf618d56ee98edf045/src/net/tcpsockopt_openbsd.go#L13-L15)

etcd won't run on OpenBSD: set keepalive period not supported

Followup https://github.com/etcd-io/etcd/pull/15812#issuecomment-1929504990 cc @Elbehery

cli: Add etcdutl snapshot hashkv command

We also need to add a changelog item, but it's OK to add it in a separate PR. cc @jmhbnz @ivanvc @ArkaSaha30 to take a second look.

etcdserver: add watchdog to detect stalled writes

This is the draft PR per our discussion in the [doc](https://docs.google.com/document/d/1U9hAcZQp3Y36q_JFiw2VBJXVAo2dK2a-8Rsbqv3GgDo/edit) @mitake @ptabor @serathius @chaochn47 @fuweid Please let me know if you have any immediate comment or concern, before I...