Benjamin Wang

Results 627 comments of Benjamin Wang

I suggest to hold off this change until golang 1.13, because go module will be the default dependency management tool at that time. Let's wait and see.

> @ahrtr @bill828 do you recall below logic in setTestEnv.sh? > > 100 if [ `uname -s` == "Darwin" ] ; then > 101 alias pms=${GOPATH}/bin/speedle-pms-mac > 102 alias ads=${GOPATH}/bin/speedle-ads-mac...

I just tried to build Speedle on my Mac, and it generated speedle-pms and speedle-ads. @caiwl So the logic you pasted isn't correct any more. @etsangsplk FYI. https://speedle.io/quick-start/

Update versioning support : - https://github.com/etcd-io/website/pull/601 - https://github.com/etcd-io/etcd/pull/14306

This PR looks good to me. @kennytm Could you rebase the PR?

@spzala we don't need merge this PR based on the discussion. Please close this one. thx

The OOM is a known issue, the workaroud AFAIK are: 1. perform compaction & defragmentation to reclaim the db file space; 2. avoid big range operation on the client side....

> Can I just delete the WAL files? It isn't recommended to manually delete the WAL files, otherwise the WAL files may not be matching the snap files. Please try...

The huge memory usage might be caused by the db file size. What's the size of the db file, which locates in `${DATA_DIR}/member/snap/db`? Please try to perform compaction + defragmentation...

I just added more log for debugging the reason why etcd fails to purge WAL file. https://github.com/etcd-io/etcd/pull/14576