Alex Herbert

Results 53 comments of Alex Herbert

Is the intention that this should match `isCreateable(String)` for all valid hex numbers and return `true` for all hex cases where a `Number` is returned from `createNumber(String)`? ```java public static...

Regarding `0x1L` the NumberUtils.createNumber and NumberUtils.isCreatable only supports the preferred type suffix on decimal numbers. You cannot specify a preferred `L` for hex integers. So this new method should match...

The value `5D0` may be valid hex digits but what are you going to do with that fact? If you want to create a number with it then nothing in...

This also includes the fix for TEXT-86 #106. Can you remove that so the only files changed are for the `JaccardSimilarity` and its test.

I do not know why `openjdk12` was in the Travis build matrix. Travis did not like it. This has just been fixed on master by @garydgregory to use `oraclejdk11` and...

FYI: This javadoc warning: ``` [WARNING] Javadoc Warnings [WARNING] warning: URL https://docs.oracle.com/javase/8/docs/api/element-list was redirected to https://docs.oracle.com/en/java/javase/19/ -- Update the command-line options to suppress this warning. ``` Is due to the...

Last commit was on Oct 21st. Is this correct or do you need to push again?

Hi @Claudenw, consolidating all the behaviour flags is a good idea. It will avoid future tests failing to set them correctly. I'll wait until you have done that for a...

A more typical approach for projects derived from Commons Parent would be to create: ``` src/site/resources/profile.japicmp ``` This will activate the JApiCmp profile in commons parent which binds the `cmp`...

Thanks for the contribution. There are a few issues to address before a detailed review. This will fail on checkstyle. You should replace all tab characters with 4 spaces and...