Alex Herbert

Results 48 comments of Alex Herbert

I would use `int Double.hashCode(double)` which effectively does the same thing but does not require as many statements, e.g. ```java public int hashCode() { if (isNaN()) { return 642; }...

The changes I requested to the tests have not been implemented. Without them the tests **could** sporadically fail.

These hashcode changes have been integrated into the master branch.

Master updated manually

I had to remove the setting in my text editor to not remove trailing space. All should be fixed now. I am not sure why GH thinks I have changed...

This cannot parse standard floating point numbers generated by String valueOf as the exponent character in that case is E. What if the exponent is negative? What if the number...

Similar to (null checks not included): ```java EnumSet.of(searchEnums[0], searchEnums).contains(testEnum) ``` This code would leverage the optimised EnumSet code for any Enum that has less than 64 members (as internally it...

The change applied to the `subArray(boolean[], ...)` also applies to 7 other `subArray` methods in the same class. Can you update to fix them all. Thanks.

Note that the javadoc mixes the use of what happens when a parameter is 'undervalue' (too small) and 'overvalue' (too large), with the effect on the parameter (undervalue set to...

No need to change the method. But I suggested changing the description of the `startIndexInclusive` too since the empty array result is for `>=` not `>`: ```Java /** * ......