commons-text icon indicating copy to clipboard operation
commons-text copied to clipboard

Published 20 hours ago • verified publisher icon apache

Text 158

Open milaKisialiova opened this issue 5 years ago • 4 comments

Fix Jaccard similarity with empty strings: Due to bug, Jaccard similarity for two empty strings returned 0.0, and the distance 1.0, now it returns similarity 1.0, and the distance 0.0

milaKisialiova avatar Mar 11 '19 10:03 milaKisialiova

This also includes the fix for TEXT-86 #106. Can you remove that so the only files changed are for the JaccardSimilarity and its test.

aherbert avatar Mar 11 '19 10:03 aherbert

Coverage Status

Coverage increased (+0.0008%) to 97.918% when pulling 61becad2c02e699a37a90a8e5369bb2fc9c20c2e on CAPS50:TEXT-158 into 700a066a71bd626df547085e2f66f3f3f0939d26 on apache:master.

coveralls avatar Mar 11 '19 10:03 coveralls

Hi @aherbert

it looks like Travis is failing in jdk 12 for a reason that is not related to this change:

install-jdk.sh 2019-01-18 II Couldn't determine a download url for 12-GPL on linux-x64

can you please have a look and advise how to move forward?

CAPS50 avatar Mar 22 '19 10:03 CAPS50

I do not know why openjdk12 was in the Travis build matrix. Travis did not like it.

This has just been fixed on master by @garydgregory to use oraclejdk11 and openjdk8. Any new work pushed to this this PR will use the new matrix from master.

The current travis results pass JDK 8 and 11 so this is not an issue.

aherbert avatar Mar 22 '19 13:03 aherbert