Andrew Hammond

names function but doesn't constrain name length

10

``` ❯ npx cdk list /Users/ahammond/Documents/ClickUp/cold-storage-cdk/node_modules/aws-cdk-lib/aws-lambda/lib/function.ts:662 throw new Error(`Function name can not be longer than 64 characters but has ${props.functionName.length} characters.`); ^ Error: Function name can not be longer than...

feat: remove the function name

11

Named functions are more trouble than they're worth. The description provides the same value, without the annoyance. Fixes: #53

The ?? operator tests for undefined rather than falsy.

Error loading webview: Error: Could not register service workers: InvalidStateError: Failed to register a ServiceWorker: The document is in an invalid state.

2

**Describe the Bug** Git Graph fails to open **Steps to Reproduce** Steps to reproduce the behaviour: 1. Cmd-Shift-P "> Git-Graph: View Git Graph (git log)" 2. ``` Error loading webview:...

lock down GitHub Actions to specific SHA

2

Per GH security docs: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions I think we should consider locking down all GH Actions that we reference by SHA instead of by tag. e.g. Before: ``` uses: actions/checkout@v3 ```...

I added password rotation to my database using https://github.com/time-loop/cdk-aurora/blob/main/src/aurora.ts#L284 However, it didn't - create the user, which didn't previously exist, so I worked around it: https://github.com/time-loop/cdk-aurora/blob/main/src/aurora.provisioner.ts#L432:16 - set the newly...

If engine is missing, assume that the user still wants to rotate the secret. If the user deliberatly tries to connect to a non-postgres database, the right place to fail...

cdk-ecr-deployment not compatible with CdkPipelines

4

I have a pipelined repo which deployed just fine... until I add cdk-ecr-deployment. Then the build stage fails because the CodeBuild doesn't have support for docker. Because... why would it?...

Fixes # --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

GitHub Packages support?

1

We currently publish all our CDK constructs to GitHub Packages. I can't get authorization from security to enable a `npmjs.com` registry. We publish a number of open-source packages and would...