aws-secrets-manager-rotation-lambdas icon indicating copy to clipboard operation
aws-secrets-manager-rotation-lambdas copied to clipboard

missing engine is not a cause for panic

Open ahammond opened this issue 5 years ago • 1 comments

If engine is missing, assume that the user still wants to rotate the secret. If the user deliberatly tries to connect to a non-postgres database, the right place to fail is in the db.connect() call.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ahammond avatar May 30 '20 04:05 ahammond

The existing approach and the one suggested in this pull request seem pretty much equivalent to me. What's the advantage of doing this?

simonmarty avatar Nov 04 '24 21:11 simonmarty