Anton Gilgur

Results 998 comments of Anton Gilgur

> @zhucan @agilgur5 I think this issue should be reopened. #12993 has been closed by #13454, but this issue has not been solved as [#12103 (comment)](https://github.com/argoproj/argo-workflows/issues/12103#issuecomment-2296174496) analized. @jswxstw You should...

> Wait informer watch failed,and then relist called. You can see that `options.Limit=0` in debug mode. this makes sense to me, although I'm not sure if this could have other...

Thanks for the great summary Jesse, that's very helpful! My only [remaining question](https://github.com/argoproj/argo-workflows/pull/13466#issuecomment-2289034747) is the effect/ramifications of the `limit=0` -> `limit=500` change here

Thanks for stress testing this! > The current way of setting the Limit is incorrect, which may result in only 500 records of informer data in certain situations, as shown...

> informer rebuilds > cache rebuilds Apparently the informer framework's resync does not do a full re-list anymore per https://github.com/argoproj/gitops-engine/pull/617#discussion_r1698660165? @wojtek-t if you have a minute to check this PR,...

> This needs documenting, with examples and the variables we can use. See also the ["Variables" page](https://argo-workflows.readthedocs.io/en/release-3.5/variables/)

### context, changed direction should be discussed For context, Isitha followed up with me on Slack and I repeated my concern about using deprecated `govaluate` [above](https://github.com/argoproj/argo-workflows/pull/13474#discussion_r1732030191). The examples here do...

> This PR has been here for a month Alan only approved it [2 weeks ago](https://github.com/argoproj/argo-workflows/pull/13474#pullrequestreview-2269999556), which was shortly after [I noticed the `govaluate` usage](https://github.com/argoproj/argo-workflows/pull/13474#discussion_r1732030191) and shortly before [your own...

> * where you feel there has been an inappropriate closed discussion, > Initially I implemented this using purely `expr` but after a chat with @Joibel we decided it was...

If Terry and others would like to tiebreak and allow adding a deprecated feature, I'm fine with that, but I think that should be properly discussed. In particular, I think...