Anton Gilgur

Results 998 comments of Anton Gilgur

Resolved my [above comment](https://github.com/argoproj/argo-workflows/pull/13343#pullrequestreview-2359030878) on simplification in https://github.com/argoproj/argo-workflows/pull/13814

It's [using](https://github.com/argoproj/argo-helm/blob/6dab5492689e9f2d389515a7059564f9d0c9fb39/.github/configs/cr.yaml#L10) GH's generated changelog [via `chart-releaser`](https://github.com/helm/chart-releaser-action). The changelog diff [does not seem configurable](https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes), so I guess this is on GH interpreting tag order incorrectly. Might be not handling monorepos...

For reference, I brought this up at [last month's Maintainers meeting](https://docs.google.com/document/d/1C71GA0XCxsyGP7Q4SYveHak5ZZcJOuaOiDCt_xHG10U/edit#heading=h.h4lsj2memkmb) and [today's Maintainers meeting](https://docs.google.com/document/d/1C71GA0XCxsyGP7Q4SYveHak5ZZcJOuaOiDCt_xHG10U/edit#heading=h.ssn1ktdom54n) to get this some traction. See the in-line links for notes there, and I think...

No, since that uses a terminal with `xterm`. If we simplified it as I [mentioned there](https://github.com/argoproj/argo-workflows/issues/13148#issuecomment-2153129909), then it could work depending on the approach

See my [review comment](https://github.com/argoproj/argo-workflows/pull/13500#pullrequestreview-2258675551). This seems like the exact use-case for the `forceFinalizerRemoval` field

Looks like this might be caused by failure of TaskResult reconciliation (so ArtifactGC didn't run yet), and so would have a duplicate root cause of #12993 and fixed by #13454....

Try running your Controller image with `:latest`, which will include #13454

To clarify, so in this scenario, no ArtifactGC Pods were launched? Since no artifacts were created > Looking at the code, `woc.allArtifactsDeleted()` is actually true, but `anyPodSuccess` prevents the deletion...

This sounds like a duplicate of #12103, although this is concretely a v3.5.5 regression whereas that one happened in v3.4. cc @jswxstw

Thanks for root causing this @jswxstw! > As a result, the outputs reported by workflowtaskresult and pod are inconsistent, and the status in workflowtaskresult is finally taken, which is wrong....