Anton Gilgur

icon indicating a website link https://linktr.ee/agilgur5

icon location Greater NYC icon location Human. Maintain: rollup-plugin-typescript2, react-signature-canvas, mst-persist, django-serializable-model, etc. Former: Argo, TSDX, etc. Contributor to many

Results 998 comments of Anton Gilgur

feat: multiple mutexes and semaphores

I haven't been feeling great the past week, so dismissed my review to unblock this. Can iterate more on docs later as I do have some thoughts on them, but...

feat: multiple mutexes and semaphores

> I haven't been feeling great the past week, so dismissed my review to unblock this. Can iterate more on docs later as I do have some thoughts on them,...

feat: multiple mutexes and semaphores

> > In that case, I am wondering whether we should have a separate "fix" to backport that errors out when both are provided. Since this feature will only land...

docs(artifacts): add note about server access

The [S3 IRSA section](https://github.com/argoproj/argo-workflows/blob/b59d7c1cd3c0191cb9a2c6ec91af47da2f21520e/docs/configure-artifact-repository.md?plain=1#L135) mentions the Server too. I would say to either follow that for now or make a new section about it properly. This page definitely needs a...

Add workflow prioritization docs

Ah this will be addressed by #13393

Replace gogoprotobuf related dependencies.

> A lot of organizations are adopting https://buf.build which is making life easier for using protobufs. Yea Buf's definitely made the ecosystem a lot more usable. The schema registry, an...

`deleteDelayDuration` JSON schema and validation mismatch

> But the schema (https://github.com/argoproj/argo-workflows/blob/v3.5.4/api/openapi-spec/swagger.json#L14403) says it should be Yea I mentioned this exact thing ask in my "Notes to Reviewers" in the PR as well as [in-line comment](https://github.com/argoproj/argo-workflows/pull/11325#discussion_r1259005153) and...

`deleteDelayDuration` JSON schema and validation mismatch

We use durations in a few places already, and this was a duration as an env var before it became part of the spec (with the exact same name), but...

`deleteDelayDuration` JSON schema and validation mismatch

This got reported [on Slack](https://cloud-native.slack.com/archives/C01QW9QSSSK/p1723635558441409) as well. Now that it's been reported twice (and unstale), I'm thinking of applying a workaround for this. The codebase has a helper [`ParseStringToDuration`](https://github.com/argoproj/argo-workflows/blob/282a0d38df8f52879f04071017dc24d320e1e4d8/pkg/apis/workflow/v1alpha1/utils.go#L9) that...

expression `{{= workflow?.outputs?.parameters?.my_param ?? 'na' }}` always return `na`

Hmm, I wonder if the parser is getting confused by the safe conditional -- since it can't directly look up `pod?.name` like it can with `pod.name`. Though IIRC, the entire...