Anton Gilgur
Anton Gilgur
Well that's interesting, CI `codegen` [failed](https://github.com/argoproj/argo-workflows/actions/runs/7689244513/job/20951411465?pr=12583). I did actually run `make codegen` with this change (for #12582), but probably wasn't fresh like it is on GH Actions. Might be an...
Ok everything else passed, so it's just `codegen` failing. I think that might be because of the `rm -rf v3` lines -- there are several individual jobs that have that...
Sure, go for it
Ran [`webpack-bundle-analyzer`](https://github.com/webpack-contrib/webpack-bundle-analyzer) (which I had wanted to do for a while, figured now's a good time if I wrote this issue already) and here are the results:  -- for `monaco-editor`. That code looks like it is almost as old as Argo CD itself (4+ years old), so...
Tiny modification, in my [above comment](https://github.com/argoproj/argo-workflows/issues/12059#issuecomment-1773859379) I accidentally analyzed a development bundle (as visible in `react-dom.development.js`), not a production bundle. A prod bundle can remove quite a bit of dev...
Also thought I'd output some Webpack performance hints/warnings (after #12150): ``` WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB). This can impact web...
That would only solve the pages portion of this issue, but not the deps portion (some large deps are used in multiple pages/routes). Ultimately, that's also just short-hand, so just...
Thanks for the detailed report! This could potentially be a bug in the underlying YAML editor or viewer deps, as YAML is supposed to be able to interpret octal. Either...
I may have found the underlying cause, though need to test a bit. Per `js-yaml`'s [4.0.0 changelog](https://github.com/nodeca/js-yaml/blob/4.1.0/CHANGELOG.md#400---2021-01-03): > Parse numbers according to YAML 1.2 instead of YAML 1.1 (`01234` is...