Anton Gilgur

Results 766 comments of Anton Gilgur

~Seems to still happen even when I [remove the `Jsonify`](https://go.dev/play/p/d2ZJC6jwUy-) and use `claims` directly. So either the `Compile` statement or the `expr.Env` is causing the empty string to be excluded~...

[Removing](https://go.dev/play/p/t2MmZWUvj7T) the `omitempty` in the `json` struct tag works. That may have other side-effects though 🤔 There might be a better way around that 🤔

Yea `omitempty` should technically be removed for all of the fields in that case, which would indeed have side-effects. This may very well affect other places that use templating as...

I already root caused it [above](https://github.com/argoproj/argo-workflows/issues/13061#issuecomment-2198587632), and yes it will happen when you have no groups.

> userInfoPath resulting in a 404 which was not being raised as an error, returning nil. If I am reading this correctly: https://github.com/argoproj/argo-workflows/blob/main/server/auth/types/claims.go#L102 That's correct for that function, but it's...

Sounds like an extension / more concrete proposal of #10396 And a variant of #12757 Regarding the specific spec -- fields are camelCase by convention in k8s, so I've edited...

> It's somewhat preferable to implement this mechanism over #12757's proposal because it's more powerful. It's also much less intuitive for the simple case that that issue is aiming for...

It doesn't seem to have added much so far per its PRs and commits, so I think it's too early to do so. Also per https://github.com/go-sprout/sprout/issues/1#issuecomment-2102561906, there will potentially be...

> Navigating to `https://SERVER/workflows/NAMESPACE/WORKFLOW_NAME` instead lands me on: > `https://SERVER/archived-workflows?namespace=NAMESPACE&name=WORKFLOW_NAME&deep=true` ~I took another look based on this and I'm thinking that the closing paren on `uiUrl` in #12172 can be...