Anton Gilgur
Anton Gilgur
> This will merge conflict with #549 (due to indentation etc changes), so it is a draft for now Rebased on top of #549 and fixed all merge conflicts, ready...
> Note: I did check that the controller cron package we use is unmaintained with no new commits landing to the default branch or releases in the last four years:...
Thanks for the detailed report! > In a Slack convo Anton suggested that #12573 may be suspect. Specifically, the only SSO change [in v3.5.5](https://github.com/argoproj/argo-workflows/blob/v3.5.6/CHANGELOG.md#v355-2024-02-29) was #12318, which is unrelated in...
From DMs: > So I am back from my long weekend - turns out that v3.4.17 has the same problem. I checked the release and it seems to have the...
Confirmed with a different user in [another Slack thread](https://cloud-native.slack.com/archives/C01QW9QSSSK/p1717095485232599?thread_ts=1715631032.025069&cid=C01QW9QSSSK) that this is a regression in 3.5.5 and that reverting to 3.5.4 fixed it
@isubasinghe any chance you could take a look at this? Related to the `expr` upgrade and changes you made in #12573. It's a P1 given that it breaks SSO RBAC
> i tried below in go playground (https://go.dev/play/) but could not reproduce the error: 🤔 There were two separate users who encountered it though, and both resolved by downgrading. That...
My intuition is that the `Eval` -> `Compile` + `Run` change is responsible somehow, as I think you suspect too
Is it when `groups` is empty maybe? The `Jsonify` (that naming is confusing as it's still very much a struct) is perhaps excluding it from the JSON and resulting map?...
Can confirm in [the playground](https://go.dev/play/p/PEbYc7Vkzo8), changing it to an empty array in the `Compile` + `Run` variant causes the error: ```go Groups: []string{}, ``` ``` panic: unknown name groups (1:43)...