Anton Gilgur
Anton Gilgur
> * [x] 10. ui/src/app/shared/components/error-panel.tsx: > * [x] 14. ui/src/app/shared/components/inline-table/inline-table.tsx: > * [x] 16. ui/src/app/shared/components/nudge.tsx: > * [x] 17. ui/src/app/shared/components/pagination-panel.tsx: > * [x] 20. ui/src/app/shared/conditions-panel.tsx: > * [x] 22. ui/src/app/shared/resources-duration.tsx:...
Some of the files listed in the opening comment are also not React components. Quick way to tell: they end in `.ts` and not `.tsx`. I think they may have...
> * [x] 36. ui/src/app/workflows/components/submit-workflow-panel.tsx: * [x] 50. ui/src/app/workflows/components/resubmit-workflow-panel.tsx: * [x] 51. ui/src/app/workflows/components/retry-workflow-panel.tsx: @toyamagu-2021 do you think you'd be able to refactor the submit/resubmit/retry workflow panels to functional components? Since...
> * [x] 2. ui/src/app/archived-workflows/components/archived-workflow-details/archived-workflow-details.tsx: > * [x] 3. ui/src/app/archived-workflows/components/archived-workflow-filters/archived-workflow-filters.tsx: > * [x] 4. ui/src/app/archived-workflows/components/archived-workflow-list/archived-workflow-list.tsx: These 3 components no longer exist as the Archived Workflows UI was merged with the...
> * [x] 6. ui/src/app/reports/components/reports.tsx: > * [ ] 7. ui/src/app/shared/components/base-page.tsx: > * [x] 35. ui/src/app/userinfo/components/user-info.tsx: > * [ ] 41. ui/src/app/workflows/components/workflow-filters/workflow-filters.tsx: > * [ ] 46. ui/src/app/workflows/components/workflows-list/workflows-list.tsx: Completed `Reports`...
> * [x] 18. ui/src/app/shared/components/resource-editor/resource-editor.tsx: > * [x] 19. ui/src/app/shared/components/tags-input/tags-input.tsx: > * [x] 40. ui/src/app/workflows/components/workflow-drawer/workflow-drawer.tsx: Completed these 3 components in #11800
> * [x] 9. ui/src/app/shared/components/dropdown/dropdown.tsx: > * [x] 15. ui/src/app/shared/components/input-filter.tsx: > * [ ] 39. ui/src/app/workflows/components/workflow-dag/workflow-dag.tsx: > * [x] 44. ui/src/app/workflows/components/workflow-timeline/workflow-timeline.tsx: > * [x] 48. ui/src/app/workflows/components/workflows-toolbar/workflows-toolbar.tsx: Would anyone like to...
> * [x] 7. ui/src/app/shared/components/base-page.tsx: > * [x] 41. ui/src/app/workflows/components/workflow-filters/workflow-filters.tsx: > * [x] 46. ui/src/app/workflows/components/workflows-list/workflows-list.tsx: Completed these all in #11891. That was actually a lot more challenging than I expected...
no worries I was sick this week with a pretty bad cold too 😷 (and am behind on some reviews as such) . hope you are feeling better!
> * [x] Signed releases ([_docs_](https://clomonitor.io/docs/topics/checks/#signed_releases)) This was completed in #9837 > * [x] License scanning ([_docs_](https://clomonitor.io/docs/topics/checks/#license_scanning)) - I believe Snyk's [security scans](https://github.com/argoproj/argo-workflows/blob/5def5289a6c010265bb9e8a6bfcd6f1bba80624b/.github/workflows/snyk.yml) do license checks as well, so I...