Anton Gilgur

Results 1000 comments of Anton Gilgur

> I believe Snyk's [security scans](https://github.com/argoproj/argo-workflows/blob/5def5289a6c010265bb9e8a6bfcd6f1bba80624b/.github/workflows/snyk.yml) do license checks as well, so I think this might just need a badge on the README to satisfy. Welp, never mind, apparently Snyk...

> The `Token-Permissions` check is actively being refined right now, so we shouldn't put too much thought into that until this issue closes: [ossf/scorecard#2338](https://github.com/ossf/scorecard/issues/2338) @eddie-knight curious if the `SECURITY-INSIGHTS.yml` checks...

> The SI was adopted by CLOMonitor (not via Scorecard) at the beginning of this month in order to streamline the hygiene checks you listed there. Is it going to...

Yea I guess I am confused as to the difference between CLOMonitor's security checks and Scorecard's checks; one would think they'd be the same. I see that Security Policy and...

I dug into the (very large) changelog for [3.4.0-rc1](https://github.com/argoproj/argo-workflows/blob/master/CHANGELOG.md#v340-rc1-2022-08-09) and the one thing that seemed potentially related to this is #8596, which added a date range filter to the UI....

Looks like this may have been _partially_ fixed by #9909 (released in 3.4.4) for `Pending` workflows specifically.

Was unable to reproduce on latest 3.5.0-rc1+. This seems like it was indeed fixed by #9909 as only a `Pending` workflow would have no `status.startedAt`. We may want to remove...

Ok I did find a pretty bad bug in the date filtering logic: when either of the date filters were cleared, no Workflows would show, as they were comparing dates...

> We may want to remove the new default in 3.4.0+ of showing only last month first if users are confused by that. Then the UI would by default match...

> Suspend/Resume a cron workflow from the UI, and monitor what workflows are currently active I think this ended up getting duplicated by #4264, which was completed in #4446 >...