Anton Gilgur

Results 283 comments of Anton Gilgur

@tczhao the test failures are unrelated, see #13002 and [Slack thread](https://cloud-native.slack.com/archives/C0510EUH90V/p1714810708644859?thread_ts=1714810708.644859&cid=C0510EUH90V) where Isitha, Alan, and I were investigating it but haven't found the root cause yet

> Test failure is due to failed to retrieve the log See also #8935 for an issue on logs in Argo v3.4. I mentioned there that setting `POD_NAMES=v1` will also...

FWIW, I recently had to make a small change to this in Argo's own UI (see https://github.com/argoproj/argo-workflows/pull/11766), and the code for pod names is limited to [this single file](https://github.com/argoproj/argo-workflows/blob/26481a2146107ad0937ef7698c27f3686f93c81e/ui/src/app/shared/pod-name.ts). You...

You might notice `podSpecPatch` a few lines below -- you can set that to change anything on the Pod

Oh and the other [remaining test failure](https://github.com/argoproj/argo-workflows/actions/runs/9028328717/job/24808748392?pr=12984) needs a change in `TestExecutorPluginsSuite/TestTemplateExecutor` to handle the now set SC fields (it was expecting them to be `nil` before): ``` executor_plugins_test.go:41: Error...

Annnd apparently Expo recently (legit 2 months ago) added support for PWAs w/ RNW 😮 See the [blog post](https://blog.expo.io/expo-cli-and-sdk-web-support-beta-d0c588221375) and the [examples repo](https://github.com/expo/web-examples/). Most of the links in the blog...

Welp, made a [web-support](https://github.com/agilgur5/react-native-manga-reader-app/tree/web-support) branch for this on top of #12 annnd it fell pretty flat 😢 There are some [issues](https://github.com/expo/expo/issues/4545) with Expo Web, but getting past that leads to...

Tried to do a workaround by adding an `iframe`, and the iframe actually _did_ load, but I was unable to parse the iframe's `document` (second error as listed [here](https://stackoverflow.com/a/36047994/)), so...

Some other workaround scripts from https://github.com/argoproj/argo-workflows/pull/12521: Simple version: ```sh cat .spelling | sort | uniq | tee .spelling > /dev/null ``` More complex skipping a few comments at the top...

> I tried `make pre-commit -B` (had to install `go` first) and it failed with `protoc` not found. Do I need to keep working my way through these, or is...