Anton Gilgur

Results 766 comments of Anton Gilgur

This change should also handle the logic we discussed in https://github.com/argoproj/argo-workflows/pull/12441#issuecomment-1925885676. With GC config, it needs to be killed without a `delete` request. If `kill` is supported and used, that...

> Found this issue which proposes a solution I would solve my issue: #12049 Yes that solves a number of issues. I'd like to implement that too, but need a...

> Sorry this is my first time reporting a security issue, so I hadn't thought about people misusing it For future reference, please use projects' `SECURITY.md` or other publicly posted...

Noting that this is a follow-up to [this Slack thread](https://cloud-native.slack.com/archives/C01QW9QSSSK/p1710303909706609?thread_ts=1710303909.706609&cid=C01QW9QSSSK) > * Above mentioned command is executed just after the `main` container is completed, so, the `wait` container is only...

I mean, at a really high-level yes, but you have to go down several layers of the call stack to get to [`SignalContainer`](https://github.com/argoproj/argo-workflows/blob/b1c37686c35b78fc93a025f37469591ef5de0c1b/workflow/signal/signal.go#L18) which actually runs the kill command. The...

> I suspect it is deeper than that; there seems to be an assumption somewhere that when the `main` container finishes, all containers should be killed and that `wait` executes...

Your comment is not quite correct, so I will correct it below. But it's not related to my root cause analysis above either, it's just a misunderstanding of the features....

> We don't have this error in the old version. What was your old version? 3.4.9? If it is a regression, knowing between which two versions would be very helpful

Gotcha. Been a lot of changes since 3.0.2. Though I took a look and [this specific code](https://github.com/argoproj/argo-workflows/blame/82ac98026994b8b7b1a0486c6f536103d818fa99/workflow/controller/controller.go#L402) hasn't been changed in years since it was written. Only thing I can...

Could try to run a debugger and inspect the variables then. Or could try to modify the code to log it out, but trying to log may itself fail.