Anton Gilgur

Results 284 comments of Anton Gilgur

@terrytangyuan I mentioned that [above](https://github.com/argoproj/argo-workflows/issues/12572#issuecomment-1909368976) already. I cc'ed you before as I thought you might have a decision regarding what should and shouldn't be built-in. Per Alan's comments though, this...

Yes I think with #10362 and #10364 there really isn't a need for this. Increasing resource limits is already possible with those combinations. Using an existing field would be better...

For reference, [Slack thread](https://cloud-native.slack.com/archives/C01QW9QSSSK/p1707815785007059?thread_ts=1707815785.007059&cid=C01QW9QSSSK) about this. You can use `podSpecPatch` to modify the `wait` container and add a volume

> We do not want the Argo workflow controller to have access to our private registries (it should not need that access, the kubernetes cluster has the required image pull...

> it seems as if the source gets dropped into a shell script and that ends up being set as the entrypoint it's in `args` actually, as your output in...

`prop-types` has been a peerDep practically since it was spun out of React 6 years ago: #3. So I'm not sure we should really change that without solid reason. Haven't...

Oh cool, thanks for the suggestion @prantlf ! Good luck on the fork and hope it does well! I also maintain a [heavily updated fork of a library](https://github.com/agilgur5/react-signature-canvas) :)

We might need to add a prop for the canvas's [`contextAttributes`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#contextattributes)

We may want to retry this since https://github.com/argoproj/pkg/pull/486 / #11704 updated to a newer and more comprehensive JSONPath library. That was released in 3.5.0-rc2