Yichun Zhang
Yichun Zhang
@georgebashi I see your point. Will you contribute a patch? It's better to be in a separate Lua class (or module), like `resty.semaphore`. I think you can just use `ngx.sleep`...
@s7v7nislands The ngx.semaphore API has already been released for a couple of months: https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/semaphore.md
They are false positives for the the same reason as lua-nginx-module.
@arohter Just a quick heads up: I will look into this soon. I'm currently too busy with other things. Sorry for the delay on my side!
@arohter Glad to hear that. This is still on my review queue though. Sorry about that.
thank you for the patch! just some quick suggestions: 1. could you remove line-trailing spaces from the code? 2. could you leave 2 blank lines between C function definitions? 3....
Hello! On Sat, Jul 14, 2012 at 1:55 PM, vadim-pavlov [email protected] wrote: > I think I've fulfilled all requests, please feel free to review and hopefully merge new feature with...
One quick question: is it better to rename "extra_headers" to "headers"? do you really want to "add" headers to the parent request's headers?
Hello! Sorry for the delay! I've been extremely busy at $work over the last week :) On Mon, Jul 16, 2012 at 8:26 PM, vadim-pavlov [email protected] wrote: > Hi! I...
@surfire91 Not yet though it's been on my TODO list. BTW, there exists work-arounds: 1. use `ngx.req.set_header` and `ngx.req.clear_header` in the parent request's Lua code, and 2. use `proxy_set_header` and...