Yichun Zhang
Yichun Zhang
OK, I had a closer look. It looks good generally and we can have it if those remaining concerns are addressed. I have the following questions or concerns: 1. we...
@pj-splunk Mind to bake a patch for that?
@alex95120 It should work regardless of the status code withou the `-s` option. Will you provide a _standalone_ and _minimal_ test case that I can run and reproduce the issue...
@p0pr0ck5 I think we'd better only add this new `decr` method to lua-resty-core's FFI-based implementation. I do not want to maintain two parallel implementations for new API functions any more...
@PAStheLoD Yeah sure. Just go ahead :)
@kushalkh You should handle any errors on the Lua land and configure the following line in your nginx.conf: ``` lua_socket_log_errors off; ``` See https://github.com/openresty/lua-nginx-module#lua_socket_log_errors
@kushalkh The second error message is a clear indication that you didn't check return values of socket operations but continued using a closed socket object.
@Angry-Rabbit For 1), that bit is for race condition handling, which should be very rare to hit but still possible in the wild. For 2), I don't understand your intention...
@Angry-Rabbit It's technically possible to adjust the count limit threshold on the fly. Will you contribute a patch for it? Thanks!
@tatdatpham Check out your nginx error.log to see why they are marked down (they are usually marked down due to failed healthcheck requests).