Yichun Zhang

Results 937 comments of Yichun Zhang

@ZTzha BTW, make sure your image request indeed goes through your `location /`, not some other location configuration blocks. You can verify that by (temporarily) enabling the nginx debugging logs.

@yitony Yes, setting an exptime helps saving shm storage in some cases. Will you create a pull request for that? Thanks! Regarding the `uncommit` method, it is documented (well, I've...

@jamesyangoc Could you please try removing other 3rd-party modules like ngx_pagespeed and see if you can still reproduce the problem? It's known that some 3rd-party modules like ngx_pagespeed _may_ break...

@yanxurui Are you using recent versions of OpenResty? Recent versions of OpenResty use our own branch of LuaJIT with special optimizations which *significantly* reduce the hash collisions in Lua string...

@yanxurui I'm glad that the latest OpenResty addresses your performance issue. I think I'd like to leave this PR as is for now. We do have plans to rewrite this...

@lebanggit I don't think I understand your question.

@SamMousa Patches welcome. BTW, such requirements can be easily and efficiently done via the ngx_http_lua module: https://github.com/openresty/lua-nginx-module/ That's why I'm reluctant to develop more and more such little things myself...

@thibaultcha Please help follow up this one. Thanks!

@youjujun It is by design. The `wait` function returns immediately upon the first terminated (or aborted) light thread. I tried your Lua example above on my side. It works as...