Ashley Anderson
Ashley Anderson
+1 for this feature As is I created a workaround by setting `buildkite-agent meta-data` for each passing step, and checking it in subsequent steps to print a message and fail...
I noticed this is being discussed in #2785 and figured I'd give my 2¢. This behavior makes sense to me as a mostly Python-brained developer, but I understand the controversy....
I will rebase and test again locally at least to make sure.
I rebased and tests all pass. I also tested manually with `napari-console==0.0.7` and the behavior feels correct. The failure in Build PR Docs is unrelated I think - looks like...
@kephale this change requires `napari-console==0.0.7` for the behavior to take effect - can you check that you have the correct version?
Oh no it looks like `PR Test / ubuntu-latest 3.8 pyside2 (pull_request)` has hung - is this a known/intermittent problem or likely something with my PR?
I agree Python enums are kinda weird and I also usually just use a class with class attributes. Subclassing both `str` and `Enum` makes it a bit more ergonomic and...
> I'd say we can consider this PR as "in mergeable state". Further work will take place as part of the extraction to a separate package. This will also unblock...
Sorry - I tried to dismiss my old review from my phone. I think it worked but might not be too clear. My initial concerns were all addressed! I will...
@Pooppap can you open this as a PR in your own fork to make it easier to review and discuss parts of the code?