Afshin Taylor Darian

Results 133 comments of Afshin Taylor Darian

Hi @cameron-toy! Thanks for the PR! This change seems useful to me. Could you please: 1. Add docstrings to the implementation in the class? 2. Add these to the tests...

@gabalafou I've added you to the "Triage" team for the `jupyterlab` GitHub org, you should be able to assign and label things, etc., now

I think handling this by looking at open and closed issues in the [Lumino 2 milestone](https://github.com/jupyterlab/lumino/milestone/1) might be good because you'll see everything that's being modified or removed, there.

The top-level comment for this PR lists out all the API changes that PR contains and is relevant here: - https://github.com/jupyterlab/lumino/pull/346

There is now a `migration.md` file in the docs that includes the documentation for iterators.

Reopening this issue because apparently "partly fixes" is [not supported by GitHub](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).

Could you please post a snippet of code that will trigger this behavior? This is likely a behavior of the underlying kernel itself (I'm assuming you are using `xeus-python`) and...

> I am in the process of designing a draft spec that I will soon share with everyone. Awesome, thank you @ibdafna! I'm looking forward to seeing your draft.

I checked with @krassowski and he said he wasn't working on this. I'll assign it to you. Please feel free to hand it off back to me or someone else...

@3coins also please take a look at the original thread where this issue comes from because it has other approaches that were suggested as well: https://github.com/jupyterlab/jupyterlab/issues/9757#issuecomment-999915671